[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful patch.

From: Alexey Abramov
Subject: [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful patch.
Date: Thu, 05 Mar 2020 21:42:01 +0100
User-agent: AquaMail/1.23.0-1556 (build: 102300002)

Many thanks! I will fix these in the next patches.


On March 4, 2020 03:25:36 Leo Famulari <address@hidden> wrote:


Thanks for these patches and sorry for the delay in review! There are a
lot of patches and it takes a while to get through them.

On Sat, Feb 22, 2020 at 09:17:49PM +0100, Alexey Abramov wrote:
* gnu/packages/java.scm: Add patch
* gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New
file. Allows you to run gradlew to run properly. Useful for debugging.

The commit message needs a couple changes, to something like this:

* gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New file.
* gnu/ (dist_patch_DATA): Add it.
* gnu/packages/java.scm (java-openjfx-build)[source]: Use it.

We don't need to describe the patch in the commit message. Instead, we
explain it in a comment at the beginning of the patch file itself. This
is easier for the people that will read the patch later. The comment
should explain what the patch does and where it came from, including
links to bug reports and external patch sources, if they exist.

We need to register the new patch file in 'gnu/', so that it
gets distributed in the Guix release process.

And finally, we need to name the package variable (java-openjfx-build)
that the patch is being used by.

Here is an example from an older commit:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]