[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39306] [PATCH] gnu: Add xsettingsd.
From: |
Marius Bakke |
Subject: |
[bug#39306] [PATCH] gnu: Add xsettingsd. |
Date: |
Thu, 30 Jan 2020 17:14:00 +0100 |
User-agent: |
Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) |
David Wilson <address@hidden> writes:
> Marius Bakke <address@hidden> writes:
>
>> It is definitively OK to disable warnings coming from dependencies. In
>> fact, that is what we are supposed to do, and used to do until the
>> switch to GCC 7.
>>
>> To clarify, when we switched to GCC 7, its search paths were changed
>> from C{,PLUS}_INCLUDE_PATH to CPATH. The only[*] difference between
>> these search paths is that headers found on the former are treated as
>> "system headers", which disables warnings.
>>
>> [*] Besides the fact that GCC 6 and later is very picky about the order
>> of entries in C_INCLUDE_PATH, which is why we had to switch; see
>> <https://issues.guix.gnu.org/issue/30756> for details.
>
> Thanks for the background, that was helpful! I've been out of the loop
> on GCC changes for a while so it's good to know that this happened.
>
> I've made the suggested changes to the summary and description, attached
> the updated patch.
Excellent, LGTM!
signature.asc
Description: PGP signature