[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39086] [PATCH 4/5] gnu: ibus: Build with emoji support.
From: |
Ricardo Wurmus |
Subject: |
[bug#39086] [PATCH 4/5] gnu: ibus: Build with emoji support. |
Date: |
Thu, 16 Jan 2020 22:10:37 +0100 |
User-agent: |
mu4e 1.2.0; emacs 26.3 |
Leo Prikler <address@hidden> writes:
> * gnu/packages/ibus.scm (ibus) [inputs]: Add unicode-emoji and
> unicode-cldr-common.
> [configure-flags]: Add flags for emoji and annotations.
This should be “arguments”, not “configure-flags”. Also: please remove
the space between “(ibus)” and “[inputs]”.
> (arguments
> `(#:tests? #f ; tests fail because there's no connection to dbus
> - #:configure-flags `("--disable-emoji-dict" ; cannot find emoji.json
> path
> - "--enable-python-library"
> + #:configure-flags `("--enable-python-library"
> + ,(string-append
> + "--with-unicode-emoji-dir="
> + (assoc-ref %build-inputs "unicode-emoji")
> + "/share/unicode/emoji")
> + ,(string-append
> + "--with-emoji-annotation-dir="
> + (assoc-ref %build-inputs "unicode-cldr-common")
> + "/share/unicode/cldr/common/annotations")
> ,(string-append "--with-ucd-dir="
> (getcwd) "/ucd")
> "--enable-wayland")
Now that the configure flags are so long I have a preference for
dropping quoting and using (list …) instead. All that unquoting looks a
little too noisy.
> @@ -241,6 +248,8 @@ conventions.")
> `(("glib" ,glib "bin") ; for glib-genmarshal
> ("gobject-introspection" ,gobject-introspection) ; for g-ir-compiler
>
> + ("unicode-emoji" ,unicode-emoji)
> + ("unicode-cldr-common" ,unicode-cldr-common)
> ;; XXX TODO: Move Unicode data to its own (versioned) package.
> ("unicode-nameslist"
> ,(origin
Oh, here is the comment I mentioned earlier!
--
Ricardo
[bug#39086] [PATCH 5/5] gnu: ibus: Disable parallel build., Leo Prikler, 2020/01/11
[bug#39086] [PATCH 2/5] gnu: Add unicode-emoji., Leo Prikler, 2020/01/16
[bug#39086] [PATCH 4/5] gnu: ibus: Build with emoji support., Leo Prikler, 2020/01/16
[bug#39086] [PATCH 3/5] gnu: Add unicode-cldr-common., Leo Prikler, 2020/01/16