[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue
From: |
Reza Alizadeh Majd |
Subject: |
[bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue |
Date: |
Tue, 07 Jan 2020 13:47:53 +0330 |
User-agent: |
Cyrus-JMAP/3.1.7-731-g1812a7f-fmstable-20200106v2 |
Hi Danny,
On Tue, Jan 7, 2020, at 1:22 PM, Danny Milosavljevic wrote:
> Hi Reza,
>
> thanks for the patch. I think that it is the right way for now.
>
> But GIO_LAUNCH_DESKTOP is not interpreted as a list by glib.
>
> It would be better to communicate intent by constructing GIO_LAUNCH_DESKTOP as
>
> (wrap-program (string-append out "/bin/pcmanfm-qt")
> `("GIO_LAUNCH_DESKTOP" =
> (,(string-append glib "/bin/gio-launch-desktop"))))
>
> .
>
> Otherwise, with ":" and "prefix" it very much sounded like a list.
>
> Also, could you make it check whether /bin/gio-launch-desktop exists and
> error out otherwise? That is in order for us to notice the workaround
> later when we move the gio-launch-desktop executable.
>
> (if (file-exists? ".........../bin/gio-launch-desktop")
> (wrap-program ........)
> (error "Could not find gio-launch-desktop"))
>
Thanks for your guidance, I updated the patch and applied both of
- GIO_LAUNCH_DESKTOP variable format
- gio-launch-desktop existence check
to this new patch.
--
Regards
Reza Alizadeh Majd
PantherX Team
0001-gnu-pcmanfm-qt-fix-double-click-issue.patch
Description: Binary data