[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.)

From: Ivan Vilata i Balaguer
Subject: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.)
Date: Sun, 15 Dec 2019 20:44:11 -0500
User-agent: Mutt/1.12.2 (2019-09-21)

Efraim Flashner (2019-12-05 11:02:36 +0200) wrote:

> With the 'staging' branch being merged into master the patch no longer
> cleanly applies.
> Also, since you've removed a patch from the gnu/packages/patches folder
> you need to remove it also from gnu/ The two other things are
> the commit message doesn't list all of the changes and with the new
> qt-build-system that would probably be a better choice than wrapping the
> binaries yourself, but with an updated patch without that I can help
> work on that since it is such a new change.

Hi!  I'm attaching a reviewed set of patches.  The first patch updates the
original one to fix the copyright line (so it applies cleanly again), the
`` line removal and commit message completeness.  The second patch
adds the update to `qt-build-system`.  From the comments in
`guix/build-system/qt.scm` I gather that no other changes are missing, but I
may be wrong.


Ivan Vilata i Balaguer --

Attachment: 0001-gnu-mumble-Update-to-1.3.0.patch
Description: Text document

Attachment: 0002-gnu-mumble-Use-qt-build-system.patch
Description: Text document

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]