guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#37730] [PATCH] Topologically sort recursively-imported packages


From: Ricardo Wurmus
Subject: [bug#37730] [PATCH] Topologically sort recursively-imported packages
Date: Thu, 12 Dec 2019 16:15:01 +0100
User-agent: mu4e 1.2.0; emacs 26.3

Ludovic Courtès <address@hidden> writes:

> Hi Brian,
>
> Brian Leung <address@hidden> skribis:
>
>>> If that’s fine with you, I’d be willing to apply this patch, and then
>>> apply other bits of your patch (the tests and stream removal) on top of
>>> it.  How does that sound?
>>
>> Sure, your patch seems clearer to me.
>
> I pushed patches that combine mine and yours:
>
>   4982de4c32 import: crate: Add recursive import test.
>   70a8e13277 import: utils: 'recursive-import' returns a list rather than a 
> stream.
>   ddd5915900 import: utils: 'recursive-import' returns packages in 
> topological order.

Thank you!

> Let me know if you notice anything wrong!

I believe the docstring of RECURSIVE-IMPORT in (guix import utils) needs
to be adjusted.  It still refers to streams.

-- 
Ricardo






reply via email to

[Prev in Thread] Current Thread [Next in Thread]