[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#38509] [PATCH] gnu: libuv: Update to 1.34.0

From: Brett Gilio
Subject: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0
Date: Fri, 06 Dec 2019 19:27:43 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Andrew Miloradovsky <address@hidden> writes:

> -    (arguments
> -     '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc.
> -       #:tests? #f))
> +    (arguments '(#:tests? #f))
> +    ;; tests 122-124 (getnameinfo_basic_ip*) fail
> +    ;;

Hi Andrew,

Thank you for your submission. I have some questions before we go
forward with this patch. First, I'd like to note that this change would
trigger a huge rebuild of thousands of dependent packages.

--8<---------------cut here---------------start------------->8---
brettg@oryx ~/Repos/guix$ ./pre-inst-env guix refresh -l libuv
Building the following 2067 packages would ensure 5397 dependent packages are 
--8<---------------cut here---------------end--------------->8---

That said, is there some particular functionality or security that is
provided with this patch? If so, it would be great if you could
elaborate on that in the Git sub-header of the commit message.

Since this patch would trigger such a massive rebuild it will need to go
to the `core-updates` branch to rest before it sees master. So having
that detail in the commit message will make it easier for us to see what
we are working with.

Lastly, just curious if there is a way to work around the issues with
tests 122-124 as shown in your above snippet. I know that the tests were
blanket disabled before, so I am just curious if there is a _better_ way
to do this, maybe i'm wrong. If the issue is that the tests require
network functionality that can usually be spoofed with some
effort. Also, stylistically, comments not on the same line as the code
they are commenting usually go before the code in question.

I hope that makes sense! Let me know if you have any questions, I am
happy to help.

Brett M. Gilio

reply via email to

[Prev in Thread] Current Thread [Next in Thread]