[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#37975] [PATCH 2/2] gnu: Add udiskie.
From: |
Pierre Neidhardt |
Subject: |
[bug#37975] [PATCH 2/2] gnu: Add udiskie. |
Date: |
Tue, 29 Oct 2019 12:10:15 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi Guillaume,
Looking great, just a few nits below:
> + (arguments
> + `(;; The tests want libappindicator, which is not available.
Why isn't available? Should we package it? URL of the lib?
> + #:tests? #f
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'wrap-gi-typelib
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out"))
> + (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
> + (wrap-program (string-append out "/bin/udiskie")
> + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))
> + #t)))))
> + (home-page "https://github.com/coldfix/udiskie")
> + (synopsis "Automounter for removable media")
> + (description
> + "The udiskie program is a udisks2 front-end that allows to manage
@command{udiskie}.
> +removeable media such as CDs or flash drives from userspace.
Typo: removable.
> +
> +Its features include:
> +
> +@itemize
> +@item automount removable media
> +@item notifications
> +@item tray icon
> +@item command line tools for manual un-/mounting
I find the "-/" syntax a bit unconventional. Maybe "(un)mounting" would be
better.
In doubt, "mounting and unmounting" works in all cases :)
> +@item LUKS encrypted devices
> +@item unlocking with keyfiles
> +@item loop devices (mounting iso archives)
iso => ISO
> +@item password caching
> +@end itemize")
=> @end itemize\n
Also maybe improve the typography of the list, e.g. add commas at the
end of every line and a period for the last line.
--
Pierre Neidhardt
https://ambrevar.xyz/
signature.asc
Description: PGP signature
- [bug#37975] [PATCH 0/2] gnu: Add udiskie., Guillaume Le Vaillant, 2019/10/29
- [bug#37975] [PATCH 1/2] gnu: Add python-keyutils., Guillaume Le Vaillant, 2019/10/29
- [bug#37975] [PATCH 2/2] gnu: Add udiskie., Guillaume Le Vaillant, 2019/10/29
- [bug#37975] [PATCH 2/2] gnu: Add udiskie., Pierre Neidhardt, 2019/10/29
- [bug#37975] [PATCH v3 1/2] gnu: Add python-keyutils., Guillaume Le Vaillant, 2019/10/29
- [bug#37975] [PATCH v3 2/2] gnu: Add udiskie., Guillaume Le Vaillant, 2019/10/29
- [bug#37975] [PATCH v3 1/2] gnu: Add python-keyutils., Pierre Neidhardt, 2019/10/30