[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37510: [PATCH 1/1] compile: Fix race condition on completion progres
|
From: |
Eric Bavier |
|
Subject: |
bug#37510: [PATCH 1/1] compile: Fix race condition on completion progress. |
|
Date: |
Sat, 28 Sep 2019 00:01:08 -0400 (EDT) |
----- On Sep 26, 2019, at 3:57 PM, Ludovic Courtès address@hidden wrote:
> Eric Bavier <address@hidden> skribis:
>
>>>> +++ b/guix/build/compile.scm
>>>> @@ -173,7 +173,8 @@ files are for HOST, a GNU triplet such as
>>>> \"x86_64-linux-gnu\"."
>>>>
>>>> (define (build file)
>>>> (with-mutex progress-lock
>>>> - (report-compilation file total completed))
>>>> + (report-compilation file total completed)
>>>> + (set! completed (+ 1 completed)))
>>>
>>> Here ‘completed’ is incremented before the thing is even started.
>>
>> Maybe a more generic name like "progress" would be appropriate?
>
> Yes, probably!
Ok, pushed with a rename to "progress" in commit 21391f8c83.
--
`~Eric