[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#37444] [PATCH] added aerc, a simple email client and its dependcies
From: |
Ludovic Courtès |
Subject: |
[bug#37444] [PATCH] added aerc, a simple email client and its dependcies |
Date: |
Thu, 26 Sep 2019 11:37:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi Martin,
Martin Becze <address@hidden> skribis:
> On 2019-09-18 09:01, Ricardo Wurmus wrote:
>> Hi Martin,
>>
>>> This adds aerc, which is a terminal based email client written in go.
>>
>> Thank you for your patch!
>>
>> Could you please separate the independent changes into separate commits
>> and add commit summaries? For example, the update of
>> go-github-com-mitchellh-go-homedir should be done separately.
>>
>> Please also explain why “inputs” had to be changed to
>> “propagated-inputs” in some packages, and mention these kind of changes
>> in the commit summary.
>>
>> Thanks!
>
> just bumping, updated patch has been made and split into commits now.
> https://issues.guix.gnu.org/issue/37444 let me know if that is ok
Like Ricardo mentioned, it would be great if patch #1 were split into
several commits, one per new package. That’s how we usually do it.
I saw your commit logs provide explanations. However, they are all on
the “subject line” of the commit log. Could you take a look at
<https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html>
regarding the format of commit logs, or run, say, “git log
gnu/packages/golang.scm” to view examples?
I could do these changes on your behalf, but I’d rather let you do it to
make sure I don’t mess up or misrepresent what you did!
Thanks,
Ludo’.
- [bug#37444] [PATCH] added aerc, a simple email client and its dependcies, Martin Becze, 2019/09/18
- [bug#37444] [PATCH] added aerc, a simple email client and its dependcies, Ricardo Wurmus, 2019/09/18
- [bug#37444] [PATCH] added aerc, a simple email client and its dependcies, Martin Becze, 2019/09/18
- [bug#37444] [PATCH] added aerc, a simple email client and its dependcies, Martin Becze, 2019/09/18
- [bug#37444] [PATCH] added aerc, a simple email client and its dependcies, Martin Becze, 2019/09/22
- [bug#37444] [PATCH] added aerc, a simple email client and its dependcies,
Ludovic Courtès <=
- [bug#37444] [PATCH v3 01/23] added go package go-github-com-mattn-go-pointer, Martin Becze, 2019/09/26
- [bug#37444] [PATCH v3 02/23] added go package go-github-com-danwakefield-fnmatch, Martin Becze, 2019/09/26
- [bug#37444] [PATCH v3 03/23] added go package go-github-com-ddevault-go-libvterm, Martin Becze, 2019/09/26
- [bug#37444] [PATCH v3 04/23] added go package go-github-com-emersion-go-imap, Martin Becze, 2019/09/26
- [bug#37444] [PATCH v3 07/23] added go package go-github-com-emersion-go-maildir, Martin Becze, 2019/09/26
- [bug#37444] [PATCH v3 08/23] added go package go-github-com-emersion-go-message, Martin Becze, 2019/09/26
- [bug#37444] [PATCH v3 05/23] added go package go-github-com-emersion-go-sasl, Martin Becze, 2019/09/26
- [bug#37444] [PATCH v3 06/23] add go package go-github-com-emersion-go-imap-idle, Martin Becze, 2019/09/26
- [bug#37444] [PATCH v3 10/23] added go package go-github-com-emersion-go-smtp, Martin Becze, 2019/09/26
- [bug#37444] [PATCH v3 09/23] added go package go-github-com-emersion-go-textwrapper, Martin Becze, 2019/09/26