[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#37412] [PATCH 2/2] services: Add the Guix Data Service.

From: Christopher Baines
Subject: [bug#37412] [PATCH 2/2] services: Add the Guix Data Service.
Date: Sun, 22 Sep 2019 13:15:42 +0100
User-agent: mu4e 1.2.0; emacs 26.3

Ludovic Courtès <address@hidden> writes:

> Christopher Baines <address@hidden> skribis:
>> +(define (guix-data-service-shepherd-services config)
>> +  (match config
>> +    (($ <guix-data-service-configuration> package user group
>> +                                          port host)
> Perhaps use ‘match-record’ here and elsewhere, to avoid mistakes when
> the record type changes.

Yeah, I've switched a couple of the match statements across to
match-record, but I've left one, as it has a couple of clauses.

>> +(define %test-guix-data-service
>> +  (system-test
>> +   (name "guix-data-service")
>> +   (description "Connect to a running Guix Data Service.")
>> +   (value (run-guix-data-service-test))))
> Nice.
> Could you add a bit to guix.texi, maybe under “Continuous Integration”?
> You don’t have to go into too much detail if you think some of the
> configuration elements are subject to change.

I forgot you mentioned the "Continuous Integration" section, so I
actually added something under a new "Guix" section, but regardless,
I've now sent some new patches, which includes some documentation.

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]