[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#35813] [PATCH] Add crate-recursive-import.

From: Brian Leung
Subject: [bug#35813] [PATCH] Add crate-recursive-import.
Date: Sat, 7 Sep 2019 23:49:59 +0200

Hi Efraim,

An updated patch is attached.

I was and still am confused why my previous patch was yielding duplicates. I'm not getting duplicates right now, even with packages that previously yielded duplicates (I tried this on ripgrep); please test and let me know if there are any issues. Maybe I fixed the issue in the course of rebasing?

And "guix import crate -r asfeusnoetuhesont" should now print "failed to download meta-data for...", though I don't know how to do this more idiomatically without using error or leave (which would end the recursive import earlier than desired). And the double quotes actually appear, which is not ideal. I'd appreciate any advice on how to clean this up.


On Thu, Aug 8, 2019 at 12:39 PM Efraim Flashner <address@hidden> wrote:
On Tue, Aug 06, 2019 at 06:03:23PM +0200, Brian Leung wrote:
> Should have sent this to you too, Ivan.
> On Tue, Aug 6, 2019 at 5:42 AM Brian Leung <address@hidden> wrote:
> > OK, I updated to remove print statements I missed.
> >
> > On Mon, Aug 5, 2019 at 7:50 PM Brian Leung <address@hidden> wrote:
> >
> >> I took Karl's changes and updated them accordingly. I've also added a
> >> small test. The patch containing his importer, my changes, and my test is
> >> attached (the commit was made using my name--not sure if I should instead
> >> apply Karl's patch).
> >>
> >

I ran 'guix import crate -r afl' on a machine where I had a bunch of
crates pre-packaged the (very shorted output looked like this:

(define-public rust-xdg

(define-public rust-xdg

(define-public rust-afl
    (name "rust-afl")
    (version "0.4.4")
        (method url-fetch)
        (uri (crate-uri "afl" version))
          (string-append name "-" version ".tar.gz"))
    (build-system cargo-build-system)
        (("rust-cc" ,rust-cc)
         ("rust-clap" ,rust-clap)
         ("rust-rustc-version" ,rust-rustc-version)
         ("rust-xdg" ,rust-xdg))
        (("rust-rustc-version" ,rust-rustc-version)
         ("rust-xdg" ,rust-xdg))))
    (home-page "")
      "Fuzzing Rust code with american-fuzzy-lop")
      "Fuzzing Rust code with american-fuzzy-lop")
    (license #f)))

I know rust-xdg is there twice, but IMO it should only be printed once.

also 'guix import crate -r rusty-fork' gives me #f
'guix import crate rusty-fork' gives me:
guix import: error: failed to download meta-data for package 'rusty-fork'

Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: 0001-gnu-Add-crate-recursive-import.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]