[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#36653] [PATCH v2] guix import stackage: default to a LTS release co

From: Ludovic Courtès
Subject: [bug#36653] [PATCH v2] guix import stackage: default to a LTS release compatible with GHC 8.4
Date: Sat, 17 Aug 2019 15:52:53 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Hi Robert,

Too bad this patch is still in the queue!  I’m not familiar with
Stackage but I trust your judgment.  One minor comment:

Robert Vollmert <address@hidden> skribis:

> In particular, this means that guix lint won't warn to update to
> versions that won't necessarily fit our package set well.
> Also some minor clean-up tweaks.
> * guix/import/stackage.scm (%stackage-url): Change to https, avoiding
> redirect log messages.
> (%default-lts-version): New field.
> (stackage-lts-info-fetch, stackage->guix-package, latest-lts-release): Use it.
> (lts-info-ghc-version): Remove unused function.
> (lts-info-packages, latest-lts-release): Fix documentation typos.


> +;;; Latest LTS version compatible with bundled ghc version.
> +(define %default-lts-version "12.26")

What about storing this elsewhere?  Perhaps in the ‘properties’ field of
the ‘ghc’ package?  That should make it easier to keep these numbers in

Besides, it’s usually clearer to separate unrelated cleanups, but it’s
no big deal in this case.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]