guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#36814] [BONUS PATCH 3/2] gnu: intel-vaapi-driver: Provide LIBVA_DRI


From: Tobias Geerinckx-Rice
Subject: [bug#36814] [BONUS PATCH 3/2] gnu: intel-vaapi-driver: Provide LIBVA_DRIVERS_PATH.
Date: Sat, 27 Jul 2019 20:50:30 +0200

Marius Bakke 写道:
Tobias Geerinckx-Rice via Guix-patches <address@hidden> writes:

* gnu/packages/video.scm (intel-vaapi-driver)[native-search-paths]:
Export LIBVA_DRIVERS_PATH when installed.

Can this be squashed into patch 1/2 in this series?

Sure. I wasn't really going to merge this as FREE BONUS PATCH, don't worry.

(libva-without-mesa)[native-search-paths]: Don't inherit any.

..and this added in a separate patch, so that the intel-vaapi-driver
change does not have to go through 'staging'?

Are you sure? This hunk is here to keep the mesa derivation unchanged. Removing (or delaying) it *will* cause all of mesa's 1436 dependents to be rebuilt. I don't think we want that.

I'm leaving the enormocomment in so I don't have to repeat it here, but I'm less sure about it now than when I wrote it. I thought this was a filthy hack, but maybe it's just mildly unconventional ;-) The documentation is very sparse indeed.

The comment could perhaps be shortened by including a link to
<https://issues.guix.gnu.org/issue/22138>.

Oh thank gods yes. I missed that bug. I'm glad this is considered important. For now, this workaround + a link seems acceptable to me.

Thanks!

T G-R

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]