[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#36658] [PATCH] gnu: Add emacs-zerodark-theme.

From: Ludovic Courtès
Subject: [bug#36658] [PATCH] gnu: Add emacs-zerodark-theme.
Date: Wed, 17 Jul 2019 15:35:14 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)


Giacomo Leidi <address@hidden> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable.

Thanks for this patch!  Below are a couple of suggestions.

> +(define-public emacs-zerodark-theme
> +  (package
> +  (name "emacs-zerodark-theme")
The indentation is off here (you can do M-q to fix it if you use

> +  (version "20190528.923")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "";
> +             version
> +             ".el"))

This URL is unstable: the file will be modified in place regularly.
Consequently, could you instead use the upstream Git repository URL
along with the ‘git-fetch’ method?

> +  (synopsis
> +    "A dark, medium contrast theme for Emacs")
Please remove “A”, as suggested by ‘guix lint’.

> +  (description
> +    "A dark theme inspired from One Dark and Niflheim.

Please write a full sentence (info "(guix) Synopses and Descriptions").

> +An optional mode-line format can be enabled with 
> 'zerodark-setup-modeline-format'.")
Please use @code as suggested by ‘guix lint’.

Could you send an updated patch?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]