[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module.
From: |
Ludovic Courtès |
Subject: |
[bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module. |
Date: |
Mon, 15 Jul 2019 18:32:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
address@hidden (Jakob L. Kreuze) skribis:
> Ludovic Courtès <address@hidden> writes:
[...]
>> In the meantime, what about this patch?
>>
>> diff --git a/guix/remote.scm b/guix/remote.scm
>> index e503c76167..8ada5c0957 100644
>> --- a/guix/remote.scm
>> +++ b/guix/remote.scm
>> @@ -76,8 +76,14 @@ result to the current output port using the (guix repl)
>> protocol."
>> (with-imported-modules (source-module-closure '((guix repl)))
>> #~(begin
>> (use-modules (guix repl))
>> - (send-repl-response '(primitive-load #$program)
>> +
>> + ;; We use CURRENT-OUTPUT-PORT for REPL messages, so redirect
>> PROGRAM's
>> + ;; output to CURRENT-ERROR-PORT so that it does not interfere.
>> + (send-repl-response '(with-output-to-port (current-error-port)
>> + (lambda ()
>> + (primitive-load #$program)))
>> (current-output-port))
>> +
>> (force-output))))
>>
>> (define* (remote-eval exp session
>
> LGTM, thanks!
Cool, pushed as 6f8eb9f1d8bc8660349658602698db36965bba5d.
>> ‘live-service-requirement’ gives you the graph of the currently loaded
>> services, but you also need the target service graph to determine what
>> to upgrade; that seems to be missing currently.
>
> Oh, good catch. Reusing 'shepherd-service-upgrade' is certainly the way
> to go, then.
I think so, which brings us back to the need to de-monadify (guix graph).
:-)
Ludo’.
- [bug#36555] [PATCH 0/2] Refactor out common behavior for system reconfiguration., Jakob L. Kreuze, 2019/07/08
- [bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module., Jakob L. Kreuze, 2019/07/08
- [bug#36555] [PATCH 2/2] guix system: Reimplement 'reconfigure'., Jakob L. Kreuze, 2019/07/08
- [bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module., Ludovic Courtès, 2019/07/13
- [bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module., Jakob L. Kreuze, 2019/07/13
- [bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module., Ludovic Courtès, 2019/07/14
- [bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module., Jakob L. Kreuze, 2019/07/15
- [bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module.,
Ludovic Courtès <=
- [bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module., Jakob L. Kreuze, 2019/07/15
- [bug#36555] [PATCH v3 0/3] Refactor out common behavior for system reconfiguration., Jakob L. Kreuze, 2019/07/16
- [bug#36555] [PATCH v3 1/3] guix system: Add 'reconfigure' module., Jakob L. Kreuze, 2019/07/16
- [bug#36555] [PATCH v3 2/3] guix system: Reimplement 'reconfigure'., Jakob L. Kreuze, 2019/07/16
- [bug#36555] [PATCH v3 3/3] tests: Add reconfigure system test., Jakob L. Kreuze, 2019/07/16
- [bug#36555] [PATCH v3 1/3] guix system: Add 'reconfigure' module., Ludovic Courtès, 2019/07/19
- [bug#36555] [PATCH v3 0/3] Refactor out common behavior for system reconfiguration., Jakob L. Kreuze, 2019/07/18
- [bug#36555] [PATCH v4 0/3] Refactor out common behavior for system reconfiguration., Jakob L. Kreuze, 2019/07/19
- [bug#36555] [PATCH v4 1/3] guix system: Add 'reconfigure' module., Jakob L. Kreuze, 2019/07/19
- [bug#36555] [PATCH v4 2/3] guix system: Reimplement 'reconfigure'., Jakob L. Kreuze, 2019/07/19