[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#36615] [PATCH] gnu: Add opencascade-occt.

From: Ludovic Courtès
Subject: [bug#36615] [PATCH] gnu: Add opencascade-occt.
Date: Fri, 12 Jul 2019 23:51:31 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Hi Paul,

Paul Garlick <address@hidden> skribis:

> * gnu/packages/maths.scm (opencascade-occt): New variable.


> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +              ";";
> +              "a=snapshot;sf=tgz;h=refs/tags/V"
> +              (string-map (lambda (x) (if (eq? x #\.) #\_ x)) version)))

I think you should use ‘git-fetch’ instead because generated tarballs
are notoriously prone to silent change.

> +    (arguments
> +     '(;; There is no test target for make.
> +       #:tests? #f

Sometimes CMake-based packages have a configure-time option like
-DWITH_TESTS=ON.  Is there something like that here?

Apart from that it LGTM.  Thank you!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]