[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#36535] [PATCH] gnu: gobject-introspection: Update absolute-shlib-pa

From: Marius Bakke
Subject: [bug#36535] [PATCH] gnu: gobject-introspection: Update absolute-shlib-path.patch.
Date: Fri, 12 Jul 2019 20:44:08 +0200
User-agent: Notmuch/0.29.1 ( Emacs/26.2 (x86_64-pc-linux-gnu)

severity 36535 important

>>>> ++def _get_default_fallback_libpath():
>>>> ++    # Newer multiple-output-optimized stdenv has an environment variable
>>>> ++    # $outputLib which in turn specifies another variable which then is 
>>>> used as
>>>> ++    # the destination for the library contents (${!outputLib}/lib).
>>>> ++    store_path = os.environ.get(os.environ.get("outputLib")) if 
>>>> "outputLib" in os.environ else None
>>>> ++    if store_path is None:
>>>> ++        outputs = os.environ.get("outputs", "out").split()
>>> gnu-build-system does not currently export an "outputs" variable.
>>> Perhaps it should?
>> Ah, I didn't realise this part of the patch was as Nix specific as it
>> is...
>> At least for the change I was trying to affect, this seems to be
>> probably redundant, or somehow doing the job. Maybe this part of the
>> patch relating to the fallback_libpath should be removed.
> I'd keep the "$outputs" logic, it sounds like a useful and easy change
> to do in gnu-build-system, although maybe not for this 'core-updates'
> round.  We can use it in package recipes for fun and profit meanwhile.

We now have a user of the $outputs variable:

Incidentally, the package was broken because of the very same feature :-)

But we can not merge this with the hard-coded /gnu/store paths, as that
is likely to cause strange problems for users with a non-default store

Unless someone steps up to fix it within a few days, I think we'll have
to revert it for now.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]