[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#36410] [PATCH] gnu: Add screenfetch.

From: Jakob L. Kreuze
Subject: [bug#36410] [PATCH] gnu: Add screenfetch.
Date: Tue, 02 Jul 2019 12:07:31 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Hi Efraim,

Efraim Flashner <address@hidden> writes:

> If 'install-file' works here then the above 6 lines can be 2, something
> like:
> (install-file (string-append source "/screenfetch.1")
>               (string-append %output "/man/man1/"))

That's certainly much clearer. Would it make sense to do the same for
'screenfetch-dev', renaming the file after copying it with
'install-file'? Or, should a '#:rename' keyword be added to
'install-file', perhaps? I don't know if it would be a useful pattern or
not, but it's an easy addition and I'd be happy to submit a separate
patch if there's any interest.

> you can use the patch-shebang function here, should help a bit.

Thanks, that seems to be just one of many hidden gems in '(guix build
utils)'. I should really skim through that whole file at some point,
these procedures would definitely make packaging much easier.

> Ideally these should wrap the binary rather than being propagated.

I'm a bit unsure as to what you mean. Should I patch the screenfetch
script to use absolute paths for the binaries of these inputs? I.e.
patch 'bc' to '/gnu/store/...-bc-1.07.1/bin/bc'?


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]