[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#36351] [PATCH 03/10] ui: 'show-what-to-build' uses 'derivation-buil
From: |
Ludovic Courtès |
Subject: |
[bug#36351] [PATCH 03/10] ui: 'show-what-to-build' uses 'derivation-build-plan'. |
Date: |
Mon, 24 Jun 2019 14:22:05 +0200 |
* guix/ui.scm (show-what-to-build)[build-or-substitutable?]: Remove.
Use 'derivation-build-plan' instead of
'derivation-prerequisites-to-build', passing it all of DRV at once, and
remove 'fold2' shenanigans and postprocessing of BUILD.
---
guix/ui.scm | 32 +++++++-------------------------
1 file changed, 7 insertions(+), 25 deletions(-)
diff --git a/guix/ui.scm b/guix/ui.scm
index 0b4fe144b6..3c67fbaa24 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -41,7 +41,6 @@
#:use-module (guix packages)
#:use-module (guix profiles)
#:use-module (guix derivations)
- #:use-module (guix combinators)
#:use-module (guix build-system)
#:use-module (guix serialization)
#:use-module ((guix licenses) #:select (license? license-name))
@@ -820,29 +819,12 @@ report what is prerequisites are available for download."
(substitution-oracle store drv #:mode mode)
(const #f)))
- (define (built-or-substitutable? drv)
- (or (null? (derivation-outputs drv))
- (let ((out (derivation->output-path drv))) ;XXX: assume "out" exists
- (or (valid-path? store out)
- (substitutable-info out)))))
-
(let*-values (((build download)
- (fold2 (lambda (drv build download)
- (let-values (((b d)
- (derivation-prerequisites-to-build
- store drv
- #:mode mode
- #:substitutable-info
- substitutable-info)))
- (values (append b build)
- (append d download))))
- '() '()
- drv))
- ((build) ; add the DRV themselves
- (delete-duplicates
- (append (map derivation-file-name
- (remove built-or-substitutable? drv))
- (map derivation-input-path build))))
+ (derivation-build-plan store
+ (map derivation-input drv)
+ #:mode mode
+ #:substitutable-info
+ substitutable-info))
((download) ; add the references of DOWNLOAD
(if use-substitutes?
(delete-duplicates
@@ -856,8 +838,8 @@ report what is prerequisites are available for download."
download))))
download))
((graft hook build)
- (match (fold (lambda (file acc)
- (let ((drv (read-derivation-from-file file)))
+ (match (fold (lambda (drv acc)
+ (let ((file (derivation-file-name drv)))
(match acc
((#:graft graft #:hook hook #:build build)
(cond
--
2.22.0
- [bug#36351] [PATCH 00/10] Add 'derivation-build-plan', improve (guix derivations), Ludovic Courtès, 2019/06/24
- [bug#36351] [PATCH 01/10] derivations: Add 'derivation-input'., Ludovic Courtès, 2019/06/24
- [bug#36351] [PATCH 03/10] ui: 'show-what-to-build' uses 'derivation-build-plan'.,
Ludovic Courtès <=
- [bug#36351] [PATCH 04/10] graph: Use 'derivation-input-derivation'., Ludovic Courtès, 2019/06/24
- [bug#36351] [PATCH 06/10] derivations: 'derivation' preserves pointer equality., Ludovic Courtès, 2019/06/24
- [bug#36351] [PATCH 07/10] derivations: 'build-derivations' can be passed derivation inputs., Ludovic Courtès, 2019/06/24
- [bug#36351] [PATCH 02/10] derivations: Rewrite and replace 'derivations-prerequisites-to-build'., Ludovic Courtès, 2019/06/24
- [bug#36351] [PATCH 10/10] ui: 'show-derivation-outputs' accepts <derivation-input> records., Ludovic Courtès, 2019/06/24
- [bug#36351] [PATCH 08/10] packages: 'specification->package+output' distinguishes "no output specified"., Ludovic Courtès, 2019/06/24
- [bug#36351] [PATCH 09/10] ui: 'show-what-to-build' accepts derivation inputs., Ludovic Courtès, 2019/06/24
- [bug#36351] [PATCH 05/10] derivations: <derivation-input> now aggregates a <derivation>., Ludovic Courtès, 2019/06/24
- bug#36351: [PATCH 00/10] Add 'derivation-build-plan', improve (guix derivations), Ludovic Courtès, 2019/06/27