[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35812: [PATCH] fix hackage cabal tests

From: Ludovic Courtès
Subject: bug#35812: [PATCH] fix hackage cabal tests
Date: Sun, 26 May 2019 23:23:27 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)


Robert Vollmert <address@hidden> skribis:

>> On 21. May 2019, at 16:48, Ludovic Courtès <address@hidden> wrote:
>> Robert Vollmert <address@hidden> skribis:
>>> Hackage cabal tests didn’t run independently due to memoization,
>>> and test-cabal-6 was failing.
>> I don’t think memoization can get in the way here: the argument list is
>> used as a key in the memoization hash table.  Thus, if you pass
>> different arguments, you get a cache miss and call the underlying
>> procedure.
>> Or am I missing something?
> I agree that memoization of a pure function shouldn’t have such effects,
> but my (limited) understanding is that hackage->guix-packages would
> cache import results by package name on the assumption that cabal
> files for the same package name don’t change between calls.

Oh, got it.

I pushed a variant of the patch as commit



reply via email to

[Prev in Thread] Current Thread [Next in Thread]