[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#35720] [PATCH] gnu: Add chocolate-doom.

From: Christopher Lemmer Webber
Subject: [bug#35720] [PATCH] gnu: Add chocolate-doom.
Date: Thu, 16 May 2019 16:03:43 -0400
User-agent: mu4e 1.2.0; emacs 26.2

Jakob L. Kreuze writes:

> Patch adding a package for Chocolate Doom, which I felt was appropriate
> as both Odamex and GZDoom are packaged in Guix.
> Regards,
> Jakob L. Kreuze

Hey Jakob!  Your patch looks good in general, though I haven't had a
chance to try building and running it yet.  Maybe just a couple of

 - I think it would be "New variable" rather than "New variables" in the
   commit message.  Not that this is a big deal, and I could fix it.
 - It would be good to test if it can run with freedoom (a libre doom
   content replacement for doom that's functionaly similar).  My guess
   is that the one change would need to be adjusting where the default
   searched WAD path is.  freedoom and gzdoom both add a reference to
   /share/games/doom so I'm guessing that's how it's found.  However
   I'm not positive about that.

Looking good though in general!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]