[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build.
From: |
Björn Höfling |
Subject: |
[bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build. |
Date: |
Mon, 6 May 2019 00:05:29 +0200 |
On Fri, 3 May 2019 15:01:24 +0200
Julien Lepiller <address@hidden> wrote:
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> "http://hg.openjdk.java.net/openjfx/8u-dev/rt"
> + "/archive/85d09981ae0d.tar.gz"))
[.. ]
> + (home-page "https://openjfx.io")
This is nit-picking:
As you are using an old version of OpenJFX, would it make more sense to
have the old homepage here:
https://wiki.openjdk.java.net/display/OpenJFX/Main
> + (license license:gpl2)));with classpath exception
There are some files with BSD-2 and BSD-3 licenses, for example:
./apps/experiments/PtyConsole/src/ptyconsole/App.java: BSD 3-clause "New" or
"Revised" License
./modules/web/src/main/native/Tools/DumpRenderTree/AccessibilityController.cpp:
BSD 2-clause "Simplified" License
There is a gradle.jar in the sources:
./gradle/wrapper/gradle-wrapper.jar
Would you use a snipped to remove it?
Otherwise, LGTM.
Björn
pgpO_BtXYLIx2.pgp
Description: OpenPGP digital signature
[bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build., Julien Lepiller, 2019/05/03
[bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build.,
Björn Höfling <=
[bug#35545] [PATCH 09/17] gnu: Add java-openjfx-graphics., Julien Lepiller, 2019/05/03
[bug#35545] [PATCH 11/17] gnu: Add java-jmapviewer., Julien Lepiller, 2019/05/03
[bug#35545] [PATCH 13/17] gnu: Add java-jboss-transaction-api-spec., Julien Lepiller, 2019/05/03
[bug#35545] [PATCH 02/17] gnu: Add java-jsonp-api., Julien Lepiller, 2019/05/03
[bug#35545] [PATCH 14/17] gnu: Add java-commons-pool2., Julien Lepiller, 2019/05/03
[bug#35545] [PATCH 12/17] gnu: Add java-svg-salamander., Julien Lepiller, 2019/05/03