[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build.

From: Björn Höfling
Subject: [bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build.
Date: Mon, 6 May 2019 00:05:29 +0200

On Fri,  3 May 2019 15:01:24 +0200
Julien Lepiller <address@hidden> wrote:

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> "";
> +                                  "/archive/85d09981ae0d.tar.gz"))

[.. ]
> +    (home-page "";)

This is nit-picking:

As you are using an old version of OpenJFX, would it make more sense to
have the old homepage here:

> +    (license license:gpl2)));with classpath exception

There are some files with BSD-2 and BSD-3 licenses, for example:

./apps/experiments/PtyConsole/src/ptyconsole/ BSD 3-clause "New" or 
"Revised" License
BSD 2-clause "Simplified" License

There is a gradle.jar in the sources:


Would you use a snipped to remove it?

Otherwise, LGTM.


Attachment: pgpO_BtXYLIx2.pgp
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]