guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#35545] [PATCH 08/17] gnu: Add java-openjfx-base.


From: Ricardo Wurmus
Subject: [bug#35545] [PATCH 08/17] gnu: Add java-openjfx-base.
Date: Sat, 04 May 2019 13:46:06 +0200
User-agent: mu4e 1.0; emacs 26.1

Julien Lepiller <address@hidden> writes:

> * gnu/packages/java.scm (java-openjfx-base): New variable.
[…]
> +       #:source-dir 
> "modules/base/src/main/java:modules/base/src/main/java8:modules/base/src/main/version-info"

This line is very long.  Could you use (string-join …) on a list of
directories instead?

> +       #:test-dir "modules/base/src/test"
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'remove-empty-file

“files”, because it’s more than one?

> +    (description "OpenJFX is a free, next generation client application

Please remove “free” and “next generation”.

-- 
Ricardo






reply via email to

[Prev in Thread] Current Thread [Next in Thread]