guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build.


From: Ricardo Wurmus
Subject: [bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build.
Date: Sat, 04 May 2019 13:48:57 +0200
User-agent: mu4e 1.0; emacs 26.1

Julien Lepiller <address@hidden> writes:

> * gnu/packages/java.scm (java-openjfx-build): New variable.
[…]
> +    ;; This is a java-8 version
> +    (version "8.202")

What does this imply?  Are there more recent versions?

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append 
> "http://hg.openjdk.java.net/openjfx/8u-dev/rt";
> +                                  "/archive/85d09981ae0d.tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))

I think it may be better to use hg-fetch here as this doesn’t look like
a stable tarball.

> +    (description "OpenJFX is a free, next generation client application
> +platform for desktop, mobile and embedded systems built on Java.  Its goal
> +is to produce a modern, efficient, and fully featured toolkit for developing
> +rich client applications.  This package contains base classes for the
> +OpenJFX distribution and helper classes for building other parts of the
> +distribution.")

I agree with what Nicolas wrote.

> +    (license license:gpl2)));with classpath exception

GPL2 only?  Please add a space before “;”.

-- 
Ricardo






reply via email to

[Prev in Thread] Current Thread [Next in Thread]