[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34698] [PATCH] gnu: add org-noter.
From: |
Ludovic Courtès |
Subject: |
[bug#34698] [PATCH] gnu: add org-noter. |
Date: |
Fri, 15 Mar 2019 23:20:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello,
Nicolò Balzarotti <address@hidden> skribis:
> ---
> gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
Could you add a commit log that follows our conventions?
> + (method url-fetch)
> + (uri (string-append
> + "https://stable.melpa.org/packages/org-noter-"
> + version
> + ".el"))
Since files on MELPA are unversioned and regularly modified in place,
could you instead use the upstream URL (presumably the GitHub repo)?
> + (synopsis
> + "A synchronized, Org-mode, document annotator")
^
‘guix lint’ probably complains about this; please remove the “A”.
> + (description
> + "The idea is to let you create notes that are kept in sync when you
> scroll through the
> +document, but that are external to it - the notes themselves live in an
> Org-mode file. As
> +such, this leverages the power of Org-mode (the notes may have outlines,
> latex fragments,
> +babel, etc...) while acting like notes that are made /in/ the document.
> +
> +Also, I must thank Sebastian for the original idea and inspiration!
> +Link to the original Interleave package:
> +https://github.com/rudolfochrist/interleave
Please change the description to describe the package contents from the
viewpoint of an outsider. See the guidelines at
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.
> + (license license:gpl3)))
The source file header explicitly says “or any later version”, so it
should be ‘license:gpl3+’.
Could you send an updated patch?
Thank you,
Ludo’.
- bug#34693: [PATCH] services: mpd: add more configuration options, (continued)
- [bug#34696] [PATCH] gnu: add r-rematch2., Nicolò Balzarotti, 2019/03/01
- [bug#34695] [PATCH] gnu: add r-rex., Nicolò Balzarotti, 2019/03/01
- [bug#34694] [PATCH] gnu: add r-styler., Nicolò Balzarotti, 2019/03/01
- [bug#34698] [PATCH] gnu: add org-noter., Nicolò Balzarotti, 2019/03/01
- [bug#34698] [PATCH] gnu: add org-noter.,
Ludovic Courtès <=
- [bug#34697] [PATCH] gnu: add r-lintr., Nicolò Balzarotti, 2019/03/01