guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#34845] [PATCH 00/30] Update LXQt to 0.14.1.


From: Danny Milosavljevic
Subject: [bug#34845] [PATCH 00/30] Update LXQt to 0.14.1.
Date: Thu, 14 Mar 2019 11:47:29 +0100

Hi,

lxqt-about is not reproducible.

The difference is:

--- /gnu/store/dmrrn7gf1flqm77rm632pcxq287va80c-lxqt-about-0.14.1
+++ /gnu/store/dmrrn7gf1flqm77rm632pcxq287va80c-lxqt-about-0.14.1-check
├── bin
│ ├── lxqt-about
│ │ ├── /gnu/store/02iklp4swqs0ipxhg5x9b2shmj6b30h1-binutils-2.31.1/bin/readelf 
--wide --decompress --hex-dump=.rodata {}
│ │ │ @@ -630,15 +630,15 @@
│ │ │    0x00416730 00000000 00000000 00000000 00000000 ................
│ │ │    0x00416740 ffffffff 0b000000 00000000 00000000 ................
│ │ │    0x00416750 18000000 00000000 41626f75 74446961 ........AboutDia
│ │ │    0x00416760 6c6f6700 00000000 00000000 00000000 log.............
│ │ │    0x00416770 00000000 00000000 00000000 00000000 ................
│ │ │    0x00416780 00000000 00020000 00010000 00010000 ................
│ │ │    0x00416790 00000000 00000000 00000001 00000001 ................
│ │ │ -  0x004167a0 00000000 00000169 7a3c9af2 00000000 .......iz<......
│ │ │ +  0x004167a0 00000000 00000169 7a3c5e56 00000000 .......iz<^V....
│ │ │    0x004167b0 00000000 00000000 00000000 00000000 ................
│ │ │    0x004167c0 000f0622 7b8f0074 00720061 006e0073 ..."{..t.r.a.n.s
│ │ │    0x004167d0 006c0061 0074006f 00720073 0049006e .l.a.t.o.r.s.I.n
│ │ │    0x004167e0 0066006f 00000000 00000000 00000000 .f.o............
│ │ │    0x004167f0 00000000 00000000 00000000 00000000 ................
│ │ │    0x00416800 000009c3 0000dea8 789ceddd cd6f1bc7 ........x....o..
│ │ │    0x00416810 1500f0bb fe8a6972 6882d86b 7d7f144d ......irh..k}..M

There are multiple culprits:

(1) aboutdialog/lxqtaboutdialog.cpp: QDate::currentDate().toString("yyyy")
(2) The environment variable QT_RCC_SOURCE_DATE_OVERRIDE is not set to 1.

I've fixed (2) now--but (1) is still a (occassional and legal) problem.

I'm building lxqt now--let's see about the remainder.

Please be sure to build with at least "guix build --rounds=2".

Attachment: pgp6vOgHVSYox.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]