guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba.


From: Christopher Baines
Subject: [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba.
Date: Fri, 08 Feb 2019 17:19:45 +0000
User-agent: mu4e 1.0; emacs 26.1

Ricardo Wurmus <address@hidden> writes:

> Björn Höfling <address@hidden> writes:
>
>>> +    (propagated-inputs
>>> +     (map (lambda (input)
>>> +            (if (string=? (car input) "ruby-cucumber")
>>> +                `("ruby-cucumber" ,ruby-cucumber-without-tests)
>>> +                input))
>>> +          (package-propagated-inputs ruby-aruba)))
>>
>> This is really nit-picking, I haven't tried it out myself and I haven't
>> used it much myself, but I think this could be written more elegant with
>> match-lambda [syntax errors might be included]:
>>
>>  (map (match-lambda
>>        (("ruby-cucumber" . pkg)
>>           `("ruby-cucumber" ,ruby-cucumber-without-tests))
>>      (input input)
>> ...)
>
> Or like this
>
>     `(("ruby-cucumber" ,ruby-cucumber-without-tests)
>       ,@(alist-delete "ruby-cucumber"
>                       (package-propagated-inputs ruby-aruba)))

Yep, that looks good to me, thanks :)

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]