[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33042] [PATCH] gnu: Add soundconverter.
From: |
Christopher Baines |
Subject: |
[bug#33042] [PATCH] gnu: Add soundconverter. |
Date: |
Fri, 19 Oct 2018 15:05:35 +0100 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Leo Famulari <address@hidden> writes:
> On Sun, Oct 14, 2018 at 09:18:10PM +0100, Christopher Baines wrote:
>> * gnu/packages/gnome.scm (soundconverter): New variable.
>
> Thanks, it's nice to have graphical programs for this sort of task :)
Yeah, thanks for taking a look. I've sent an updated patch :)
>> + (patches
>> + (list
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://salsa.debian.org/multimedia-team/soundconverter"
>> + "/raw/master/debian/patches/"
>> +
>> "0002-Only-fetch-profiles-if-GConf-is-still-available.patch"))
>> + (sha256
>> + (base32
>> + "00nxpbkz7ihzrbz91ms7bd2mjgyhkbxpaa8zxj4xnkv4pjmg61hh")))))))
>
> I think it's better if we include this file in our source code, since
> it's not very big and Debian's code infrastructure URLs seem to change
> every few years. Also, the URL is not versioned, so maybe the patch
> would change in the future.
Sure, I've included the file now. This patch has been merged upstream,
so hopefully it can be removed here when the next release comes out.
>> + (add-after 'unpack 'fix-POTFILES.in
>> + (lambda _
>> + (substitute* "po/POTFILES.in"
>> + (("soundconverter/gconfstore\\.py") ""))))
>
> Please add an explanatory comment for this.
I have done. This has also been fixed upstream, so hopefully can also be
removed on the next release.
>> + (add-after 'install 'wrap-rhythmbox
>> + (lambda* (#:key inputs outputs #:allow-other-keys)
>> + (let ((out (assoc-ref outputs "out"))
>> + (python-path (getenv "PYTHONPATH"))
>> + (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
>> + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
>> + (wrap-program (string-append out "/bin/soundconverter")
>> + `("PYTHONPATH" ":" prefix (,python-path))
>> + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))
>> + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))))
>> + #t)))))
>
> If possible, I think it's better to use the python-build-system's wrap
> phase for PYTHONPATH. The hplip package has an example.
I've changed this now.
>> + (synopsis "Audio file converter for the GNOME Desktop")
>
> It works in i3, too :)
I couldn't quite work out how better to get across that it's a graphical
application, as compared to a command line tool. But, as you say, it's
not specific to GNOME.
signature.asc
Description: PGP signature
[bug#33042] [PATCH] gnu: Add soundconverter., Christopher Baines, 2018/10/19