[bug#32870] [PATCH 4/6] gnu: ruby-sass-spec: Fix spec expectation.

[Christopher Baines]

Julien Lepiller <address@hidden> writes:

> Le Sat, 29 Sep 2018 11:45:00 +0100,
> Christopher Baines <address@hidden> a écrit :
>
>> This fixes building ruby-sass with Ruby 2.5.
>>
>> * gnu/packages/ruby.scm (ruby-sass-spec)[arguments]: Add patch-test
>> phase to fix the expectation of one of the tests.
>> ---
>>  gnu/packages/ruby.scm | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
>> index c039df1559..a7dd82cf02 100644
>> --- a/gnu/packages/ruby.scm
>> +++ b/gnu/packages/ruby.scm
>> @@ -5457,7 +5457,14 @@ strings or files.")
>>         ("ruby-terminfo" ,ruby-terminfo)))
>>      (arguments
>>       ;; No Rakefile
>> -     `(#:tests? #f))
>> +     `(#:tests? #f
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'patch-test
>> +           (lambda _
>> +             (delete-file "spec/values/colors/alpha_hex-3.5/error")
>> +             (substitute*
>> "spec/values/colors/alpha_hex-3.5/expected_output.css"
>> +               (("string") "color")))))))
>>      (home-page "https://github.com/sass/sass-spec";)
>>      (synopsis "Test suite for Sass")
>>      (description "Sass Spec is a test suite for Sass.  Test cases
>> are all in
>
> If you don't enable tests, why bother fixing them?

Good question, maybe the comment could be improved. The tests are for a
implementation of Sass, so in this case, the motivation is allowing
upgrading the ruby-sass package in Guix (which runs these tests) and the
general Ruby 2.5 upgrade.

Running the tests here would be a bit difficult with Guix, as you'd need
to avoid a circular dependency problem, but I think just running them
when build ruby-sass is fine.

signature.asc
Description: PGP signature