[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#32346] [PATCH 1/6] services: tor: Add a system test.

From: Ludovic Courtès
Subject: [bug#32346] [PATCH 1/6] services: tor: Add a system test.
Date: Mon, 20 Aug 2018 22:02:49 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi Chris,

Chris Marusich <address@hidden> skribis:

> * gnu/services/networking.scm (tor-configuration->torrc): Set PidFile to
> /var/run/tor/ in the base torrc configuration.
> (tor-shepherd-service) <start>: Call make-forkexec-constructor/container with
> a new #:pid-file argument to tell Shepherd where to find the PID file.  Add a
> a new <file-system-mapping> to its existing #:mappings argument to share
> /var/run/tor with the the container.
> (tor-hidden-services-activation): Update docstring.  Create /var/run/tor and
> set its permissions so only the tor user can access it.
> * gnu/tests/networking.scm (%test-tor, %tor-os): New variables.
> (run-tor-test): New procedure.

LGTM!  Great work.

> +      ;; Allow TOR to write its PID file.

Nitpick: I think the maintainers no longer consider the name an acronym
and write it as “Tor”, not “TOR”.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]