[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31736] [PATCH] Add an opam importer
From: |
Ludovic Courtès |
Subject: |
[bug#31736] [PATCH] Add an opam importer |
Date: |
Mon, 09 Jul 2018 14:44:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello Julien,
Julien Lepiller <address@hidden> skribis:
> Here is a new version. What do you think?
I think it looks great. :-)
> From b3fd75a804a4264cb083584591a3e589886d96c8 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <address@hidden>
> Date: Wed, 6 Jun 2018 19:14:39 +0200
> Subject: [PATCH] guix: Add opam importer.
>
> * guix/scripts/import.scm (importers): Add opam.
> * guix/scripts/import/opam.scm: New file.
> * guix/import/opam.scm: New file.
> * tests/opam.scm: New file.
> * Makefile.am: Add them.
> * doc/guix.texi (Invoking guix import): Document it.
[...]
> address@hidden opam
> address@hidden opam
> address@hidden ocaml
> +Import metadata from the @uref{https://opam.ocaml.org/, Opam} package
> +repository used by the OCaml community.
Nitpick: the proper spelling is “OPAM” and “OCaml”, so I think you need
to fix these above (in the concept index as well.)
Otherwise LGTM!
As a next step, you can add an OPAM updater, which will hopefully take
you no more than a few lines of code (see the bottom of cpam.scm, for
example.)
:-)
Thank you!
Ludo’.