[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage

From: Julien Lepiller
Subject: [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage
Date: Fri, 22 Jun 2018 22:22:46 +0200

Le Fri, 22 Jun 2018 21:54:45 +0200,
address@hidden (Ludovic Courtès) a écrit :

> Could you clarify which issue this fixes?
> Also, I think you really want ‘native-search-paths’ and not
> ‘search-paths’.  The latter is meant to be used by things like
> cross-compilers.
> Thanks,
> Ludo’.

The issue was that a part of the code was only partially patched. It
looked like:

plugdir = ALSA_PLUGIN_DIR;
envplugdir = getenv("ALSA_PLUGIN_DIR");
if(envplugdir != NULL)
  plugdir = envplugdir;
sofile = malloc(sizeof(plugdir) + ...);
sprintf(sofile, "%s/", ALSA_PLUGIN_DIR);

If at compilation time ALSA_PLUGIN_DIR is bigger than the runtime
$ALSA_PLUGIN_DIR, we are in trouble: alsa-lib will crash because of a
buffer overflow. Otherwise, it just didn't care about $ALSA_PLUGIN_DIR.
The native-search-paths vs search-paths is a bit confusing... I need to
read the manual more carefully I guess.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]