[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#31687] [PATCH] services: Add dnsmasq-service-type.

From: 宋文武
Subject: [bug#31687] [PATCH] services: Add dnsmasq-service-type.
Date: Fri, 08 Jun 2018 23:45:26 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> Hello!
> Thanks for this patch, that looks like a useful service to have!
> 宋文武 <address@hidden> skribis:
>> address@hidden @code{no-negcache?} (default: @code{#f})
>> +When true, disable negative caching.
> Minor issues:
>   • The general guideline is to avoid abbreviations in identifiers—we’re
>     using the language that comes with ‘call-with-current-continuation’,
>     after all.  ;-)
>   • Another guideline is to avoid double-negations and the likes.
> So in this example, I would recommend:
>   ‘negative-caching?’ (default: #t)

Agree, I like this naming guideline, pushed :-)

> I think there’s a couple of other abbreviations.

It’s not clear to me whether other options are abbreviations or not or
worth to expand.  eg: ‘no-hosts?’ and ‘no-resolv?’, they’re refer to the
well-known ‘/etc/hosts’ and ‘/etc/resolv.conf’ files, what could we use

reply via email to

[Prev in Thread] Current Thread [Next in Thread]