[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#31399] [PATCH] import: elpa: Implement recursive import.

From: Ludovic Courtès
Subject: [bug#31399] [PATCH] import: elpa: Implement recursive import.
Date: Fri, 01 Jun 2018 22:40:08 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hello Oleg!

Oleg Pykhalov <address@hidden> skribis:

>> Oleg, could you factorize what’s common between the two importers in
>> (guix import utils) like Ricardo suggests?
> OK, here is a patch:

That was fast.  :-)

> From 80015053776fb8b3aad6ae730c0e32f655536d9e Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <address@hidden>
> Date: Wed, 30 May 2018 19:08:50 +0300
> Subject: [PATCH] import: utils: Add recursive-import.
> * doc/guix.texi (Invoking guix import): Document elpa recursive import.
> * guix/import/cran.scm (cran-guix-name, cran-recursive-import): New
> procedures.
> (recursive-import): Remove procedure.
> * guix/import/elpa.scm (elpa-package->sexp): Return package and
> dependencies values.
> (elpa-guix-name, elpa-recursive-import): New procedures.
> * guix/import/utils.scm (guix-name, recursive-import): New procedures.
> * guix/scripts/import/cran.scm (guix-import-cran): Use
> 'cran-recursive-import' procedure.
> * guix/scripts/import/elpa.scm (show-help, %options): Add recursive
> option.
> (guix-import-elpa): Use 'elpa-recursive-import'.


I’d find it clearer to have a first patch that moves code from cran.scm
to utils.scm, and a second patch containing the ELPA changes.  No big
deal though.

Please double-check that tests/{elpa,cran}.scm still pass, but if they
do, I think you can go ahead and push.

Thank you!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]