[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#31490] [PATCH] gnu: Add emacs-cmake-mode.

From: Marius Bakke
Subject: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode.
Date: Tue, 22 May 2018 17:21:28 +0200
User-agent: Notmuch/0.26.2 ( Emacs/25.3.1 (x86_64-pc-linux-gnu)

Oleg Pykhalov <address@hidden> writes:

> Maxim Cournoyer <address@hidden> writes:
> […]
>>> +             (substitute* "Auxiliary/CMakeLists.txt"
>>> +               (("install\\(FILES cmake-mode.el \
>>> +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") ""))))
>> Nitpick: I'd use a regexp to match the text following cmake-mode.el on
>> the line to make it more resilient to any future changes. Otherwise this
>> LGTM :)
> Agree, pushed as f037673c3133ae7453794f1f62eecebf9d06b092

'core-updates' is currently live on Hydra:

Since we already have substitutes for CMake and many dependents, this
commit will have to wait until the next rebuild cycle.  Can you revert
it on 'core-updates' and resubmit the patch to 'core-updates-next'?

PS: Please also end the phase on #t ;-)


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]