[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#31239] Make alsa find its plugins

From: Danny Milosavljevic
Subject: [bug#31239] Make alsa find its plugins
Date: Thu, 17 May 2018 08:01:43 +0200

Hi Julien,

good idea!

The indentation in the patch files is off (alsa-lib uses tabs in its source 

Also, what is 0001-Add-support-for-a-ALSA_PLUGIN_DIR-environment-variab.patch
embedded in this patch for?  Maybe for upstream?  Nice :)

You already patch the individual files in alsa-lib.

Note: It would be possible to use

++      char* plugdir = getenv("ALSA_PLUGIN_DIR") ?: ALSA_PLUGIN_DIR;

instead of

++      char* plugdir = ALSA_PLUGIN_DIR;
++        char* envplugdir = getenv("ALSA_PLUGIN_DIR");
++        if(envplugdir != NULL)
++            plugdir = envplugdir;

(especially since it's repeated multiple times) but maybe that's too obscure.

So LGTM except for the indentation and extra patch file!

Attachment: pgpoqJiSeZ3TJ.pgp
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]