guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#31244] [PATCH] ffmpeg 4.0 update patch series


From: Ludovic Courtès
Subject: [bug#31244] [PATCH] ffmpeg 4.0 update patch series
Date: Mon, 23 Apr 2018 15:08:23 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hello Rutger,

Rutger Helling <address@hidden> skribis:

> this patch series updates ffmpeg to 4.0. Since I found that a few
> packages fail to build with ffmpeg 4.0 I've also added address@hidden for
> compatibility.
>
> Furthermore I've removed ffmpeg-git and changed mpv to build with
> ffmpeg 4.0 instead.

This all looks good to me, but I have one request: could you squash all
the changes, except perhaps the one removing ‘ffmpeg-git’?

The rationale is that each commit should leave the repo in a “good”
state, which would not be the case if we first install the patch that
upgrades ffmpeg and only then apply the ffmpeg → ffmpeg-3.4 changes.

I hope that’s fine with you.

Thanks for working on it!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]