guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#31087: [PATCH] gnu: Add libcgroup.


From: Tomáš Čech
Subject: bug#31087: [PATCH] gnu: Add libcgroup.
Date: Tue, 10 Apr 2018 12:05:59 +0200
User-agent: Mutt/1.9.4 (2018-02-28)

On Mon, Apr 09, 2018 at 10:35:45PM +0200, Ludovic Courtès wrote:
Hello,

Tomáš Čech <address@hidden> skribis:

 * gnu/packages/linux.scm (libcgroup): New variable.

[...]

+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; tests try to mount cgroup filesystem and fails because it seems it
+         ;; can't be mounted twice
+         ;; let's disable it
+         (delete 'check))))

Simply write #:tests? #f.

+    (native-inputs
+     `(("bison" ,bison)
+       ("flex" ,flex)
+       ("linux-pam" ,linux-pam)))

Should ‘linux-pam’ be in ‘inputs’ rather than ‘native-inputs’?

Otherwise LGTM, thanks!

Both things addressed, result pushed.

Thanks for review!

S_W

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]