[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30744] [PATCH] tests: mail: Add test for dovecot.
From: |
Clément Lassieur |
Subject: |
[bug#30744] [PATCH] tests: mail: Add test for dovecot. |
Date: |
Fri, 09 Mar 2018 11:16:19 +0100 |
User-agent: |
mu4e 1.0; emacs 25.3.1 |
Oleg Pykhalov <address@hidden> writes:
> Hello Clément,
>
> Clément Lassieur <address@hidden> writes:
>
>> Oleg Pykhalov <address@hidden> writes:
>
> […]
>
>>> + ;; Give the service time to start talking.
>>> + (wait-for-file "/var/run/dovecot/master.pid" marionette)
>>
>> Could you put it in a test context (test-assert with file-exists? for
>> example, see tests/messaging.scm)?
>
> OK.
>
> I replaced ‘(wait-for-file …)’ and a comment with:
> --8<---------------cut here---------------start------------->8---
> ;; Check Dovecot service's PID.
> (test-assert "service process id"
> (let ((pid
> (number->string (wait-for-file "/var/run/dovecot/master.pid"
> marionette))))
> (marionette-eval `(file-exists? (string-append "/proc/" ,pid))
> marionette)))
> --8<---------------cut here---------------end--------------->8---
Cool, thank you!
> […]
>
>>> + (match (scandir TESTBOX/new)
>>> + ((cwd .. message-file)
>>
>> You need to use double quotes, like ("." ".." message-file) I believe.
>
> It works. Thank you!
>
> […]
>
> I think it's ready for a push to ‘origin/master’. WDYT?
Sure, you can push to master :-)
- [bug#30744] [PATCH 1/2] services: dovecot: Copy dovecot.conf to /etc/dovecot., Oleg Pykhalov, 2018/03/07
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Oleg Pykhalov, 2018/03/07
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Clément Lassieur, 2018/03/07
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Oleg Pykhalov, 2018/03/08
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Oleg Pykhalov, 2018/03/08
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Clément Lassieur, 2018/03/08
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Oleg Pykhalov, 2018/03/09
- [bug#30744] [PATCH] tests: mail: Add test for dovecot.,
Clément Lassieur <=
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Oleg Pykhalov, 2018/03/09
[bug#30744] [PATCH 1/2] services: dovecot: Copy dovecot.conf to /etc/dovecot., Clément Lassieur, 2018/03/07