[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30604] [PATCH 3/4] linux-initrd: Add kmod.
From: |
Mathieu Othacehe |
Subject: |
[bug#30604] [PATCH 3/4] linux-initrd: Add kmod. |
Date: |
Sun, 25 Feb 2018 15:05:24 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.3.1 |
Hi Danny,
Here are some small remarks,
> + ;; Make modprobe available as /sbin/modprobe so the kernel finds it.
> + (if kmod
> + (begin
You can use "when" to avoid "begin".
> + (define version
> + (car
Prefer match to car/cdr use.
> + (filter
> + (lambda (name)
> + (not (string-prefix? "." name)))
> + (scandir module-dir))))
> +
> + (display "VERSION")
> + (display version)
> + (newline)
(format #t "VERSION" ~a~%" version) would be shorter.
> + ; -E
Why is this commented ?
> + "-F" (string-append #$linux "/System.map")
> + version)
> + #t)))
>
Thanks,
Mathieu
[bug#30604] [PATCH v2 0/6] Load Linux module only when supported hardware is present., Danny Milosavljevic, 2018/02/25
- [bug#30604] [PATCH v2 4/6] linux-boot: Load kernel modules only when the hardware is present., Danny Milosavljevic, 2018/02/25
- [bug#30604] [PATCH v2 6/6] vm: Make the virtio-blk is uniquely identifyable in /sys., Danny Milosavljevic, 2018/02/25
- [bug#30604] [PATCH v2 1/6] gnu: kmod: Split off kmod-minimal., Danny Milosavljevic, 2018/02/25
- [bug#30604] [PATCH v2 2/6] gnu: Add kmod-minimal-static., Danny Milosavljevic, 2018/02/25
- [bug#30604] [PATCH v2 5/6] vm: Allow qemu-image builder to load Linux kernel modules., Danny Milosavljevic, 2018/02/25
- [bug#30604] [PATCH v2 3/6] linux-initrd: Add kmod., Danny Milosavljevic, 2018/02/25