[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29359] [PATCH 13/31] gnu: Add java-joda-time.
|
From: |
Ricardo Wurmus |
|
Subject: |
[bug#29359] [PATCH 13/31] gnu: Add java-joda-time. |
|
Date: |
Mon, 05 Feb 2018 14:32:31 +0100 |
|
User-agent: |
mu4e 1.0-alpha3; emacs 25.3.1 |
Björn Höfling <address@hidden> writes:
> * Finally, remove the (zero?..), as the result ignored, the result of
> the sourrunding lambda will be the final statement, the #t.
I agree with your other comments, but not with this one :)
The return value of “system*” is not a boolean. This is why we use
“zero?”.
However, we should be using “invoke” instead of “(zero? (system* …))” as
we are slowly transitioning towards throwing exceptions upon errors in
build phases.
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net