Thanks for the good feedback. Please consider the attached
Thanks for the patch.
+(define-module (gnu packages ai)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix utils)
+ #:use-module (guix download)
+ #:use-module (guix packages)
+ #:use-module (guix build-system cmake)
+ #:use-module (guix git-download)
+ #:use-module (gnu packages))
I think machine-learning.scm would be a good home for this
package, so a new file wouldn't be needed.
+ (name "libfann")
+ (version "d71d54788b")
The last release is 129 commits behind and it has been some
time, so I think you are right - we should package from a git
Usually we package from git using this style though (i.e.
reason for not using the release, use of 'file-name', and a
version that includes the last release followed by
;; There are no recent releases so we package from git.
(version (string-append "1.6-1." (string-take commit
(file-name (string-append name "-" version
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/libfann/fann.git")
+ (commit version)))
+ (build-system cmake-build-system)
+ `(#:tests? #f))
I see from the website:
Once you have installed the library you
can test it out by going to the examples directory and type
runtest, which will compile the examples and run a
few of them to test that everything is working.
Is that possible? Ideally, since there are tests it would
be good to run them.
+ (home-page "http://leenissen.dk/fann/wp/")
+ (synopsis "Fast Artificial Neural Network")
+ "FANN is a free open source neural network library, which implements
+multilayer artificial neural networks in C with support for both fully
+connected and sparsely connected networks.")
+ (license license:lgpl2.1)))
Otherwise LGTM. Can you send an updated patch please?