[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#29610] [PATCH] gnu: games: Add quakespasm.

From: Kei Kebreau
Subject: [bug#29610] [PATCH] gnu: games: Add quakespasm.
Date: Tue, 19 Dec 2017 10:32:34 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

nee <address@hidden> writes:

> Am 18.12.2017 um 17:52 schrieb Kei Kebreau:
>> A few things:
>> * Please end the "fix-makefile-paths" phase with a #t.
>> * It turns out that the license is actually gpl2+.
>> * The description's indentation seems a bit early and weird. That is, we
>>   can have up to 80 characters per line in our description, and some of
>>   the description can be adjusted accordingly.
> GJ spotting all of this. Here is the updated patch.

One more nitpick: our commit messages tend not to include the name of
the file being added to, so they look like

gnu: Add quakespasm.

as opposed to

gnu: games: Add quakespasm.

I've fixed that bit, though, and this patch is otherwise great! I've
pushed this to master.

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]