[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#29660] [PATCH] gnu: notmuch: Move elisp directory and generate auto

From: Marius Bakke
Subject: [bug#29660] [PATCH] gnu: notmuch: Move elisp directory and generate autoloads.
Date: Wed, 13 Dec 2017 08:16:50 +0100
User-agent: Notmuch/0.25.3 ( Emacs/25.3.1 (x86_64-pc-linux-gnu)

Arun Isaac <address@hidden> writes:

> Marius Bakke <address@hidden> writes:
>> Arun Isaac <address@hidden> writes:
>>> * gnu/packages/mail.scm (notmuch)[arguments]: Move elisp files to
>>> share/emacs/site-lisp/guix.d/notmuch-<version>.
>>> Add make-autoloads phase.
>> I had to dive into emacs-build-system to understand what this patch
>> does.  AFAICT the purpose is to move the emacs files to a versioned
>> subdirectory instead of "polluting" site-lisp
> Yes, this is what the configure flags do. And, all other emacs packages
> in Guix follow this convention. So, I thought it appropriate for notmuch
> to do the same.

Makes sense.

>> and that's why the make-autoloads phase is necessary?
> The make-autoloads phase generates autoloads for notmuch commands so
> that the full elisp files are loaded only at the last moment when some
> notmuch command is actually invoked. This reduces the emacs startup
> time. Again, all emacs packages in Guix have autoloads.


>> I haven't tested it, but LGTM.
> Shall I push?


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]