[bug#29445] [PATCH] gnu: Add roguebox-adventures.

[Leo Famulari]

On Sat, Nov 25, 2017 at 04:09:28PM -0500, Kei Kebreau wrote:

Thanks! Overall LGTM, but I have some nitpicks...

> +      (package
> +        (name "roguebox-adventures")
> +        (version (string-append "2.1.2." revision "." (string-take commit 
> 7)))

How about (version (git-version "2.1.2" revision commit)) ?

> +        (source
> +         (origin
> +           (method git-fetch)
> +           (uri (git-reference
> +                 (url 
> "https://git.postactiv.com/themightyglider/RogueBoxAdventures";)
> +                 (commit commit)))

And similarly, (file-name (git-file-name name version))

> +             (replace 'build
> +               (lambda* (#:key outputs #:allow-other-keys)
> +                 (let* ((out    (assoc-ref outputs "out"))
> +                        (data   (string-append
                                 ^
There are too many spaces here --| and also in the install phase.

> +                   (mkdir-p bin)
> +                   (mkdir-p doc)
> +
> +                   (copy-file "main.py"
> +                              (string-append bin "/roguebox-adventures"))
> +                   (chmod (string-append bin "/roguebox-adventures") #o555)
> +
> +                   (for-each (lambda (file)
> +                               (copy-recursively file
> +                                                 (string-append data "/" 
> file)))
> +                             '("AUDIO" "FONT" "GRAPHIC" "LIB" "LICENSE"
> +                               "icon_big.png" "icon_small.png"))
> +
> +                   (copy-file "DOC" (string-append doc 
> "/roguebox-adventures"))

And we could simplify a bit by using install-file instead of mkdir-p and
copy-file.

signature.asc
Description: PGP signature