guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28126: [PATCH 1/1] gnu: Add emacs-browse-at-remote.


From: Alex Kost
Subject: bug#28126: [PATCH 1/1] gnu: Add emacs-browse-at-remote.
Date: Mon, 04 Sep 2017 22:49:57 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Oleg Pykhalov (2017-09-04 11:39 +0300) wrote:

> Hello Alex,
>
> Alex Kost <address@hidden> writes:
>
>
>> This package does not require "dash", so I removed it from here...
>
> It requires according to build logs, 
> http://hydra.gnu.org/build/2253531/log/raw

Oops, indeed.  I thought I tested the modified version of your patch,
but apparently I built your original patch, that's why the build was
successful for me.  Thank you for pointing!

At first I was confused, as "browse-at-remote" does not require "dash".
But then I realized where this "dash" dependency comes from:
"browse-at-remote" requires "f" and "f" requires "dash".

So "dash" is not needed to be in 'propagated-inputs' (as it is
propagated by "f").  As for the tests, I realized that this package is
intended to use 'ert-runner' to run the tests, so using it simplifies
the 'check' phase:

  
http://git.savannah.gnu.org/cgit/guix.git/commit/?id=8505d34829b99744a36d72dd583768f1e49210a6

Hopefully, it will be built successfully this time :-)

-- 
Alex






reply via email to

[Prev in Thread] Current Thread [Next in Thread]