[bug#27851] Update eyed3. ([PATCH 2/2])

[Thomas Danckaert]

Another patch, another question: eyed3's test suite uses an archive of
mp3 files, at least some of which were not produced by the program
authors (there's even a Cypress Hill cover art file in the archive :-)).
I added the archive as a native input, but have no idea if this is OK.
Can such a native input also end up as a cached substitute on hydra?  In
that case, I think Guix would infringe on the copyright of the artists,
and we'd better just disable the tests.

Your thoughts?

thanks!

Thomas

>From 6f207141fbe9af153a930227233756fe34497897 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <address@hidden>
Date: Thu, 27 Jul 2017 16:47:53 +0200
Subject: [PATCH 2/2] gnu: eyed3: Update to 0.8, build with python3.

* gnu/packages/mp3.scm (eyed3): [source] Update to 0.8.
[arguments]: No longer build with python-2.  Add phase 'unpack-testdata'.
[propagated-inputs]: Add python-six and python-grako.
[native-inputs]: Don't use python2 variants; remove python2-sphinx and
python2-coverage; add python-factory-boy, python-pytest and testdata.
---
 gnu/packages/mp3.scm | 33 +++++++++++++++++++++++++++------
 1 file changed, 27 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 8a3a5809c..36351280c 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -459,7 +459,7 @@ compression format (.mpc files).")
 (define-public eyed3
   (package
     (name "eyed3")
-    (version "0.7.10")
+    (version "0.8")
     (source (origin
              (method url-fetch)
              (uri (string-append
@@ -467,14 +467,35 @@ compression format (.mpc files).")
                   version ".tar.gz"))
              (sha256
               (base32
-               "0wjicszs64ksj2y5jbk09yjd08znc1qnarlq8ssmx13f2d4x59wq"))))
+               "1dcswb0f6w3b05s1v43pq8fmavkd5g88ysndn9160wlaa1v9n40h"))))
     (build-system python-build-system)
     (arguments
-     `(#:python ,python-2))
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'unpack-testdata
+           (lambda* (#:key inputs #:allow-other-keys)
+             (system* "tar" "-xzf"
+                      (assoc-ref inputs "eyed3-testdata")
+                      "--transform" "s/eyeD3-test-data/data/"
+                      "-C" "src/test")
+             #t))
+         (replace 'check
+           (lambda _
+             (zero? (system* "make" "test")))))))
+    (propagated-inputs
+     `(("python-six" ,python-six)
+       ("python-grako" ,python-grako)))
     (native-inputs
-     `(("python2-nose" ,python2-nose)
-       ("python2-sphinx" ,python2-sphinx)
-       ("python2-coverage" ,python2-coverage)))
+     `(("eyed3-testdata"
+        ,(origin
+           (method url-fetch)
+           (uri "http://nicfit.net/files/eyeD3-test-data.tgz";)
+           (sha256
+            (base32
+             "1qpwwa343i6zc7j1dadpx395bmfvcn7vr56ncijrn8a72w71kzlb"))))
+       ("python-nose" ,python-nose)
+       ("python-factory-boy" ,python-factory-boy)
+       ("python-pytest" ,python-pytest-3.0)))
     (synopsis "MP3 tag ID3 metadata editor")
     (description "eyeD3 is a Python tool for working with audio files,
 specifically mp3 files containing ID3 metadata (i.e. song info).  It provides a
-- 
2.13.2