[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#27682] [PATCH 2/2] gnu: Add lxc.
From: |
Marius Bakke |
Subject: |
[bug#27682] [PATCH 2/2] gnu: Add lxc. |
Date: |
Fri, 14 Jul 2017 19:09:54 +0200 |
User-agent: |
Notmuch/0.24.2 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) |
宋文武 <address@hidden> writes:
> * gnu/packages/virtualization.scm (lxc): New package.
Thanks!
[...]
> + (arguments
> + '(#:configure-flags
> + '("--sysconfdir=/etc"
> + "--localstatedir=/var")
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bashcompdir (string-append out
> "/etc/bash_completion.d")))
> + (zero? (system*
> + "make" "install"
> + (string-append "bashcompdir=" bashcompdir)
> + ;; Thoses files will be handled by system services.
> + "LXCPATH=/tmp/var/lib/lxc"
> + "localstatedir=/tmp/var"
> + "sysconfdir=/tmp/etc"
> + "sysconfigdir=/tmp/etc/default"))))))))
If these are not important, why not set them to $out/etc, $out/var and
so on? /tmp seems like a dangerous default to me, since any unprivileged
user can populate these directories.
LGTM apart from that.
signature.asc
Description: PGP signature