[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27483] [PATCH] gnu: Add python-pass-git-helper.

From: Arun Isaac
Subject: [bug#27483] [PATCH] gnu: Add python-pass-git-helper.
Date: Sun, 25 Jun 2017 22:52:44 +0530

Thanks for the patch!

> +(define-public python-pass-git-helper
> +  (package
> +    (name "python-pass-git-helper")

Since, this is an application, not a python library, this package should
not have the "python-" prefix. It should just be called pass-git-helper.

> +    (version "0.3")

The latest version is 0.3.1. However, this is only available on the
project's github releases page. Could you try with that?

> +    (description
> +     "A git credential helper implementation which allows to use pass, the
> +standard unix password manager, as the credential backend for your git
> +repositories.  This is achieved by explicitly defining mappings between hosts
> +and entries in the password store.")

Descriptions should use full sentences. Could you rephrase the first
sentence to comply?

> +    (license license:lgpl3)))

The license is lgpl3+. Look at line 17 of

Everything else LGTM. Could you send an updated patch?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]